Merged
Conversation
https://github.com/ipfs/kubo/releases/tag/v0.23.0 Support for /quic (Draft 29) was removed, so remove it from `services.kubo.settings.Addresses.Swarm`. The changelog says that there have been some fixes to the FUSE mountpoint functionality but the test still requires the workaround, so leave that unchanged.
github-actions
bot
added
6.topic: nixos
Merged
12 tasks
Luflosi
added
the
8.has: upstream changes reviewed
ofborg
bot
added
11.by: package-maintainer
Member
|
Result of 2 packages blacklisted:
7 packages built:
|
fabianhjr
reviewed
Oct 12, 2023
fabianhjr
reviewed
Oct 12, 2023
fabianhjr
approved these changes
Oct 12, 2023
Member
fabianhjr
left a comment
fabianhjr
left a comment
There was a problem hiding this comment.
lgtm, didn't test functionality
Contributor
Author
|
Thank you! |
Member
|
Thank you for diligently maintaining packages. UwU |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/ipfs/kubo/releases/tag/v0.23.0
Support for /quic (Draft 29) was removed, so remove it from
services.kubo.settings.Addresses.Swarm.The changelog says that there have been some fixes to the FUSE mountpoint functionality but the test still requires the workaround, so leave that unchanged.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)